Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added custom override of hotkeys based on zuliprc file #1447

Closed
wants to merge 1 commit into from

Conversation

jamesdchu
Copy link

What does this PR do, and why?

This PR edits the keys.py file to enable custom hotkey mapping. This means that users can change the zuliprc file to get their desired hotkey mappings.

External discussion & connections

  • Discussed in #zulip-terminal in topic
  • Fully fixes #
  • [x ] Partially fixes issue Enable remapping hotkeys #1439
  • Builds upon previous unmerged work in PR #
  • Is a follow-up to work in PR #
  • Requires merge of PR #
  • Merge will enable work on #

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • [x ] Adding automated tests for new behavior (or missing tests)
  • [ x] Existing automated tests should already cover this (only a refactor of tested code)

@zulipbot zulipbot added the size: XL [Automatic label added by zulipbot] label Dec 5, 2023
@jamesdchu jamesdchu closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: XL [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants