Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boxes/views: Adopt urwid_readline for all editors. #1492

Merged
merged 1 commit into from
May 9, 2024

Conversation

Niloth-p
Copy link
Collaborator

@Niloth-p Niloth-p commented May 4, 2024

What does this PR do, and why?

Adopts urwid_readline.ReadlineEdit for all the editors in Zullip Terminal.
The panel search boxes are the only remaining editors not using urwid_readline.ReadlineEdit.

External discussion & connections

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

The panel search boxes were the only remaining editors
not using urwid_readline.ReadlineEdit.
@zulipbot zulipbot added the size: XS [Automatic label added by zulipbot] label May 4, 2024
@neiljp neiljp added the area: UI General user interface update label May 9, 2024
@neiljp neiljp added this to the Next Release milestone May 9, 2024
@neiljp neiljp merged commit e32ae3e into zulip:main May 9, 2024
21 checks passed
@neiljp
Copy link
Collaborator

neiljp commented May 9, 2024

@Niloth-p Thanks for the small but effective PR 👍

Since we have the message search already also using a ReadlineEdit, I didn't see an issue with merging this now, since the help is already slightly inconsistent. However, I'd like to see a prompt update to the help category related to only this, so that we ensure this doesn't get lost. Other help category updates are important, but potentially independent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: UI General user interface update size: XS [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants