bugfix: keys/hotkeys: Revert minor changes to improve documentation. #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few changes in fb9f20b had no apparent issue with UI navigation, but unintended consequences with regard to triggering custom actions. This commit therefore reverts a subset of that commit to allow those to proceed as before. In particular, scrolling beyond the current list of messages was not possible with the renamed keys, as the generated key was 'down' but the listed entry was 'Down'. Similarly with other directions, page up/down, and End. docs/hotkeys.md regenerated.
neiljp
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few changes in fb9f20b had no apparent issue with UI navigation, but
unintended consequences with regard to triggering custom actions. This
commit therefore reverts a subset of that commit to allow those to
proceed as before.
In particular, scrolling beyond the current list of messages was not
possible with the renamed keys, as the generated key was 'down' but the
listed entry was 'Down'. Similarly with other directions, page up/down,
and End.
docs/hotkeys.md regenerated.