Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page for managing exports. #10798

Open
rishig opened this issue Nov 9, 2018 · 10 comments · May be fixed by #15932
Open

Add page for managing exports. #10798

rishig opened this issue Nov 9, 2018 · 10 comments · May be fixed by #15932

Comments

@rishig
Copy link
Member

rishig commented Nov 9, 2018

Quick notes:

  • URL can be realm_url/export
  • Should have three radio buttons: I consent, I do not consent, and No response, with a Save button.
  • Admins should be able to see the list of users in each of the three categories (can just be a three-column table)
  • I can add all the explanatory text later

The database table that stores who has consented or not can be called UserExportConsent.
RealmAuditLog event_type can be USER_EXPORT_CONSENT_CHANGED.

@hackerkid, this could be a good project for you, while I finish merging the billing work?
One of the things that makes turning billing on scary is that we'll potentially have to manage a lot of export requests.

@zulipbot
Copy link
Member

zulipbot commented Nov 9, 2018

Hello @zulip/server-misc members, this issue was labeled with the "area: export/import" label, so you may want to check it out!

@rishig
Copy link
Member Author

rishig commented Nov 9, 2018

Labelled with export, but possibly we should start a new label called "support"?

@timabbott
Copy link
Sponsor Member

If you like; I tend to just go with tagging things that would be good to get done soon as a priority.

@whoodes
Copy link
Collaborator

whoodes commented Sep 2, 2019

@hackerkid have you worked on this already, or could I take a look at it?

@whoodes
Copy link
Collaborator

whoodes commented Sep 5, 2019

@zulipbot claim

@rishig
Copy link
Member Author

rishig commented Sep 6, 2019

Admins should be able to see the list of users in each of the three categories (can just be a three-column table)

Thinking about this now, a much better design is just a two-column table with name and consent status.

We should also get rid of the third "No response" option.

@rishig
Copy link
Member Author

rishig commented Sep 6, 2019

One more thing is that collecting consent etc. should only be live for a week. I.e. the flow should be:

  • Admin clicks "start collecting consent"
  • Users consent or say they don't consent
  • At any point in the 7 days since the start of step 1, the admin can click "export" to export with whoever has given consent at that time. They can do this multiple times (up to 5/wk).
  • After a week is up, they'll have to start a new consent cycle to do the export

So the db table collecting consents should probably look something like

class UserExportConsent
    user
    YES = 1
    NO = 2
    response = small int
    something like an export_id    
    last_updated = autoupdate with timezone_now

@zulipbot
Copy link
Member

zulipbot commented Sep 17, 2019

Hello @whoodes, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@whoodes whoodes linked a pull request Jul 26, 2020 that will close this issue
@edith007
Copy link
Collaborator

edith007 commented Mar 1, 2021

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Apr 3, 2021

Hello @edith007, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants