Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance styling for long message truncation to be reasonably stylable #10890

Open
timabbott opened this issue Nov 26, 2018 · 2 comments
Open
Labels
area: markdown difficult Issues which we expect to be quite difficult help wanted

Comments

@timabbott
Copy link
Sponsor Member

timabbott commented Nov 26, 2018

This is an iteration on #10887, and a somewhat low priority (since it's not a common situation in any case and probably a bit tricky to get right), but it would be good to make it look nicer.

One option is to (1) have it add somewhat more special syntax (e.g. <message_truncated>), rather than [message truncated] at the end of the message, and (2) have a markdown processor phase that runs super early (to avoid getting caught inside a code block or something) check if the message ends with that syntax; if so, it'd replace the syntax with an HTML span at the end of the message that we could later style appropriately.

Another option would be just to have the code that truncates it pass an attribute, e.g. message_truncated=True into the markdown processor; the problem with that is that we won't have the data stored in the database to find out, so we wouldn't be able to correctly rerender such messages.

@timabbott timabbott added help wanted area: markdown difficult Issues which we expect to be quite difficult labels Nov 26, 2018
@zulipbot
Copy link
Member

Hello @zulip/server-markdown members, this issue was labeled with the "area: markdown" label, so you may want to check it out!

@gaharavara
Copy link
Collaborator

@zulipbot claim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: markdown difficult Issues which we expect to be quite difficult help wanted
Projects
None yet
Development

No branches or pull requests

3 participants