Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for Unicode requires pressing Enter twice #13093

Open
andersk opened this issue Aug 28, 2019 · 5 comments
Open

Searching for Unicode requires pressing Enter twice #13093

andersk opened this issue Aug 28, 2019 · 5 comments

Comments

@andersk
Copy link
Member

andersk commented Aug 28, 2019

You can search for an ASCII keyword by typing it in the search box and pressing Enter once, but to search for a Unicode keyword you need to type it and press Enter twice.

@timabbott
Copy link
Sponsor Member

Fascinating. I wonder what causes that.

@zulipbot
Copy link
Member

Hello @zulip/server-search members, this issue was labeled with the "area: search" label, so you may want to check it out!

@FMota0
Copy link

FMota0 commented Sep 12, 2019

@zulipbot claim

@zulipbot
Copy link
Member

Hello @FMota0!

Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels.

If this is your first time here, we recommend reading our guide for new contributors before getting started.

@FMota0
Copy link

FMota0 commented Sep 16, 2019

The problem is that when an Unicode character is typed it triggers the 'compositionend' event, but this event is used to handle the case where the user lefts the search bar using enter, so the first enter is used to "left" the search bar, the second one is triggers the search on the 'keyup' event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants