Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs testing: Workaround the ratelimitting on Github Links. #14255

Open
aero31aero opened this issue Mar 19, 2020 · 3 comments
Open

docs testing: Workaround the ratelimitting on Github Links. #14255

aero31aero opened this issue Mar 19, 2020 · 3 comments

Comments

@aero31aero
Copy link
Member

aero31aero commented Mar 19, 2020

Recently, we have had quite a lot of failures in CI due to HTTP 429 Too Many Requests error from our github.com/zulip links. After this was reported in # automated testing, we merged a fix: b25e02a.

We should try to figure out a way to properly test GitHub links in CI and then eventually reenable testing github.com/zulip links.

tools/test-documentation is the relevant test suite.

@zulipbot
Copy link
Member

Hello @zulip/server-testing members, this issue was labeled with the "area: testing-infrastructure" label, so you may want to check it out!

@timabbott
Copy link
Sponsor Member

We should be able to do some combination of skipping testing of GitHub search links and verifying the paths exist in the repository that we're testing, to fix this.

@timabbott
Copy link
Sponsor Member

git grep BaseDocumentationSpider is helpful for finding the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants