Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message_fetch: Support storing multiple contiguous blocks of history #16697

Open
timabbott opened this issue Nov 3, 2020 · 2 comments
Open
Labels
area: message feed (uncategorized) difficult Issues which we expect to be quite difficult priority: high

Comments

@timabbott
Copy link
Sponsor Member

This is a feature that likely only makes sense to do once we've completed #15131, but might be a design consideration for how we complete that effort.

Ideally, the message_list_data data structures would support caching more than one contiguous block of message history. The obvious use case is when we're loading the home_msg_list data:

  • We want to fetch message history around the first_unread message, because that's where we'll land users when they click around the UI at places with unread messages.
  • We want to also fetch message history around the latest messages, because that is where we'll land users when they click around the UI on places without unread messages, and is also what we need to display Recent Topics data.

We ideally want this feature for narrowed message lists as well, at least once we've done #15131, since that would support rendering message history without going to the server in more cases.

I'm not sure what the right way to structure this is; one idea would be to support multiple message_list_data objects for a given filter, one for each contiguous segment; then the FetchStatus logic (etc.) would all work naturally, and we'd just merge the objects once their message ID ranges overlap. Certainly that version would only make sense to consider once we've finished #15131.

@ryanreh99 @amanagr FYI.

@timabbott timabbott added area: message feed (uncategorized) priority: high difficult Issues which we expect to be quite difficult labels Nov 3, 2020
@zulipbot
Copy link
Member

zulipbot commented Nov 3, 2020

Hello @zulip/server-message-view members, this issue was labeled with the "area: message view" label, so you may want to check it out!

@timabbott
Copy link
Sponsor Member Author

#23812 has a writeup of important preparatory work towards this goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: message feed (uncategorized) difficult Issues which we expect to be quite difficult priority: high
Projects
None yet
Development

No branches or pull requests

2 participants