New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jira integration doesn't escape ] in topic header #20642
Comments
Thanks for the report! I agree this is a bug. I'm not sure what the cleanest way to do this escaping is off the top of my head. |
Hello @zulip/server-integrations members, this issue was labeled with the "area: integrations" label, so you may want to check it out! |
@ElliotSilver can you advise a bit more on the issue, not quite sure whats going on. is it just the extra "[" thats the issue or are you missing one? |
Also @ElliotSilver is there any chance you can get a test webhook event for this for us to test the fix with? |
@adambirds The Jira ticket title was "Extra ]". The Jira integration takes the title, turns it into a link to the ticket, and makes it into the first line of the message, so a ticket with a title of
which renders as:
However, if the Jira title includes a close bracket, e.g., "Remove extra ]", then the integration turns the first line of the message into
which doesn't render correctly:
I suspect we need to escape the close bracket in order to get proper display:
I don't know if there are other characters that might break the link rendering. As for getting a test webhook, I'm just an end user. If it's something I can collect, let me know how and I can try. Perhaps @jmandel has access to that side of things. |
I understand a bit better now. Shouldn't need a test webhook. Thanks @ElliotSilver |
@zulipbot claim |
Hello @adambirds, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
See https://chat.fhir.org/#narrow/stream/179297-committers.2Fnotification/topic/tracker-item/near/266079874.
The title is supposed to be "Extra ]" ("extra" close bracket). It looks like the close bracket is messing up the link parsing. I assume the bracket needs to be escaped.
The text was updated successfully, but these errors were encountered: