Handle guests when creating streams

[xeruf]

When creating a new general stream within our small company, I want everyone of the company to be onboard, but not our customers who joined in as guests. Thus it would be nice to have the ability to add all non-guests to a new stream.

This will probably best solved once #19525 is implemented, but in the meantime, there could be a button "Uncheck Guests" (or "Toggle Guests" or "Check only members") inbetween "Check All" and "Uncheck All".

[yashd26]

@zulipbot claim

[alya]

Thanks for the request @xeruf ! @showell FYI

[alya]

@algo-byte this issue is not ready to work on. Unless specifically discussed, please choose from issues marked as "help wanted" or "good first issue".

[yashd26]

@alya thanks for letting me know, will keep that in mind. Also, should I be closing my PR?

[yashd26]

@zulipbot abandon

[alya]

Yeah, it probably make sense to close the PR, because the flow for adding users will change a lot after @showell completes his project.

[xeruf]

But is that project gonna be done soon? Why not merge the intermediate proposed solution?

[alya]

That project is actively under way. Reviewing and merging a contributor's PR takes significant work from the core team, which it doesn't make sense to apply in this case.

[zulipbot]

Hello @zulip/server-streams members, this issue was labeled with the "area: stream settings" label, so you may want to check it out!

[timabbott]

Well, critically we also haven't discussed what design makes sense here -- there's a range of UI components that could be used for this feature.

[xeruf]

The component can be the same as the other text-buttons, as @algo-byte implemented. The PR is tiny and the choice is not for the long run anyways, so I don't see why we should hold off in discussion here. I don't see how that PR would take significant review effort either.