-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape
sometimes does not work in YouTube previews
#21274
Comments
@zulipbot claim |
Welcome to Zulip, @Kevinland123! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip! Here's some tips to get you off to a good start:
As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site. See you on the other side (that is, the pull request side)! |
Hello @Kevinland123, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days. You can reclaim this issue or claim any other issue by commenting Thanks for your contributions, and hope to see you again soon! |
still working |
@zulipbot claim |
@zulipbot unclaim |
@zulipbot claim |
Hello! I've been looking at this bug for a minute and I don't believe there is a way to fix it without disabling Youtube functionalities, as there is no way to access a keypress once the focus shifts to the youtube player. I also looked into the ability to populate the keypress out, and that doesn't seem like a viable option either. Let me know if I am wrong. |
@zulipbot unclaim |
@zulipbot claim |
Hello @roanster007, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again. We look forward to your valuable contributions! |
@zulipbot claim |
Expected: The YouTube preview popup closes, and user goes back to the narrow from which the video was opened
Actual: Nothing (observable) happens
As Tim mentions, this may be because of some focusing issue after the video is played, because Escape works as expected just after step 1 (before step 2).
See https://chat.zulip.org/#narrow/stream/9-issues/topic/Escape.20in.20YouTube.20previews for the chat discussion.
The text was updated successfully, but these errors were encountered: