Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off notification bot for resolving streams #23016

Open
lzmartinico opened this issue Sep 21, 2022 · 7 comments
Open

Turn off notification bot for resolving streams #23016

lzmartinico opened this issue Sep 21, 2022 · 7 comments
Labels
feedback wanted new feature A proposed new feature for the product

Comments

@lzmartinico
Copy link

When a moderator resolves a very old topic, all subscribers to the parent stream get notified of this, and the topic gets moved to the top of the list. The realm admins should be able to configure an option for turning notification bot off for topic resolution (this could be a per-stream setting)

@alya alya added feedback wanted new feature A proposed new feature for the product labels Sep 22, 2022
@alya
Copy link
Contributor

alya commented Sep 22, 2022

Hm, given the situation you describe, would you want notifications to depend on whether or not the topic is old?

@alya
Copy link
Contributor

alya commented Sep 22, 2022

There is also an option to demote resolved topics in the left sidebar; we'd have to think about how exactly that would work.

@lzmartinico
Copy link
Author

@alya I think it would sense to have that option, but I would also want to see a way to disable notification for any topic being resolved

@lzmartinico
Copy link
Author

Hm, given the situation you describe, would you want notifications to depend on whether or not the topic is old?

This case could actually be handled with a modal similar to what you get when, on moving a message, you are asked whether to notify the original or destination topic

@alya
Copy link
Contributor

alya commented Oct 3, 2022

Hmm, maybe that's right... The tension here is that it's nice to keep resolving topics feeling quick / lightweight.

@ffdybuster
Copy link

I personally like to know who resolved a topic and when, but I also find the message annoying (and that this moves the topic up). Maybe it could be possible to insert that message as "already read" in a way that the topic doesn't bubble up? Or maybe not add a message, but show some "resolved information" below the last message. Maybe similar to resolved review discussions on GitHub?

(I do understand that there is probably no nice way to implement this without larger modifications; I just wanted to put this idea here in case someone has a better way to provide something like this with less invasive changes.)

@FeldrinH
Copy link

FeldrinH commented Sep 3, 2023

I agree with @ffdybuster. I think that ideally the 'has marked topic as resolved' messages would stay, but they would be treated as some kind of special topic metadata rather than messages, so they don't trigger a message notification and don't bump the stream to the top in the list of active topics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feedback wanted new feature A proposed new feature for the product
Projects
None yet
Development

No branches or pull requests

4 participants