Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are forks in package.json still needed? #23746

Closed
RaitoBezarius opened this issue Dec 4, 2022 · 1 comment
Closed

Are forks in package.json still needed? #23746

RaitoBezarius opened this issue Dec 4, 2022 · 1 comment
Assignees

Comments

@RaitoBezarius
Copy link

Hi there, I am trying to package Zulip server in NixOS.

I see there are two forks in package.json for source-maps and postcss-media-minimax.

Are those still needed because upstream do not have the changes? Is there anything tracking merging the required changes in upstream?

I ask because it makes it quite hard to package, plus, it is complicated to reason on supply chain security with this kind of things.

Thank you a lot!

@andersk
Copy link
Member

andersk commented Dec 16, 2022

Yes, we are tracking these.

We are interested in adopting Nix, so we’re willing to consider changes that make it easier—but we do make use of the ability to occasionally fork dependencies from Git and need to preserve it.

@andersk andersk closed this as completed Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants