Disable up/down keyboard navigation when adding subscribers via stream settings. #29690
Comments
|
Hello @zulip/server-streams members, this issue was labeled with the "area: stream settings" label, so you may want to check it out! |
|
@zulipbot claim |
|
@Kirsty21 We noticed that you have not made any updates to this issue or linked PRs for 10 days. Please comment here if you are still actively working on it. Otherwise, we'd appreciate a quick If we don't hear back, you will be automatically unassigned in 4 days. Thanks! |
|
@zulipbot abandon |
|
@zulipbot claim |
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes zulip#29690
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes zulip#29690
|
Heya, I've submitted a small PR to fix this issue. It's still missing some tests and might be a bit rough since this is the first time getting my hand dirty on some frontend stuff, but the desired behavior has been achieved. Let me know what you think whenever you have the time to check it. 👍 @laurynmm |
|
Deleted my earlier comment since it is irrelevant now |
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes zulip#29690
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes zulip#29690
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes zulip#29690
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes zulip#29690
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes zulip#29690.
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes zulip#29690.
Add a rule to the switch_rows(event) function to avoid switching stream row when pressing up/down key by checking the current URL hash and the add_subscribers_pill focus state. Add a utility function to hash_parser to help implement new switch_rows behavior mentioned above. Fixes #29690.
Currently, when adding subscribers to a stream (via the stream settings overlay), using the up/down arrow key moves the focus from the input to the streams list (on the left). Steps to reproduce this are:
Instead, when the Add subscribers input is selected in the streams setting overlay, using the up/down arrow keys shouldn't do anything. See relevant CZO thread.
Screenshot of subscribers tab of stream settings overlay
The text was updated successfully, but these errors were encountered: