Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make keyboard navigation work for show/hide user list button #29465

Open
alya opened this issue Mar 26, 2024 · 7 comments · May be fixed by #29781 or #29869
Open

Make keyboard navigation work for show/hide user list button #29465

alya opened this issue Mar 26, 2024 · 7 comments · May be fixed by #29781 or #29869

Comments

@alya
Copy link
Contributor

alya commented Mar 26, 2024

Following up on #29342, the left/right arrow keys should work for navigating between the show/hide user list button and the help menu.

@rs545837
Copy link
Collaborator

@zulipbot claim

@rs545837
Copy link
Collaborator

rs545837 commented Mar 29, 2024

I added a PR, I have somewhat resolved the issue and am pretty close to getting the complete logic. I am open to suggestion if any.

@rs545837 rs545837 removed their assignment Mar 30, 2024
@asub10
Copy link
Collaborator

asub10 commented Apr 3, 2024

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Apr 3, 2024

Welcome to Zulip, @asub10! We just sent you an invite to collaborate on this repository at https://github.com/zulip/zulip/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to Zulip!

Here's some tips to get you off to a good start:

As you work on this issue, you'll also want to refer to the Zulip code contribution guide, as well as the rest of the developer documentation on that site.

See you on the other side (that is, the pull request side)!

@zulipbot
Copy link
Member

zulipbot commented Apr 14, 2024

@asub10 You have been unassigned from this issue because you have not made any updates for over 14 days. Please feel free to reclaim the issue if you decide to pick up again. Thanks!

@asub10
Copy link
Collaborator

asub10 commented Apr 14, 2024

@zulipbot I am still actively working on this issue

@asub10
Copy link
Collaborator

asub10 commented Apr 21, 2024

@zulipbot claim

@rs545837 rs545837 linked a pull request Apr 22, 2024 that will close this issue
12 tasks
@asub10 asub10 linked a pull request Apr 27, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment