Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a stream owner/permission concept. #3783

Closed
showell opened this issue Feb 23, 2017 · 43 comments
Closed

Create a stream owner/permission concept. #3783

showell opened this issue Feb 23, 2017 · 43 comments

Comments

@showell
Copy link
Contributor

showell commented Feb 23, 2017

This ticket basically replaces #566, and I'm creating a new ticket to draw more attention to the concept.

We would like to have the notion of a "stream owner," who is a person that can admin particular streams without having full-realm-wide admin powers. Stream owners would be able to do things like forcibly remove users from the stream, change the description, and rename the stream.

One of the nuances discussed on #566 is that we need to be thoughtful about how we allow stream owners to leave a stream. (We either want to prevent streams from becoming ownerless, or we need to ensure that admins can still do all the stream administration as needed.)

@showell
Copy link
Contributor Author

showell commented Feb 23, 2017

If you work on this ticket, you should also consider more advanced permissions models for streams, such as the one discussed in #425. We occasionally hear use cases for wanting to invite folks to streams with read-only permissions (or even entire realms).

@penCsharpener
Copy link

could this be added to some road map, please? For coorporate use this is really quite useful to have.

@timabbott
Copy link
Sponsor Member

See #1122 for an implementation we'll want to consult when picking this up again.

@penCsharpener
Copy link

I might add that today I wasn't able to make a public stream private although I'm an admin because I hadn't created that stream. The person who created the stream couldn't do it either. The only work around was to make them admin for a moment, change the stream setting and revoking admin rights again. This is probably not a desired workflow.

@YJDave
Copy link
Collaborator

YJDave commented Jan 10, 2018

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Jan 20, 2018

Hello @YJDave, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 14 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@rishig
Copy link
Member

rishig commented Feb 8, 2018

Let's call the following "basic stream management":

  • Change stream name
  • Change stream description
  • Unsubscribe people
  • Make public stream private
  • Delete (archive) stream

The current resolution is:

  • All admins can perform basic stream management on all streams, including private streams they do not belong to
  • There is at most a single stream admin, who is the stream creator. The stream admin can perform basic stream management of that stream.

It's "at most a single stream admin", since the stream creator can leave the stream.
In later versions we may add the ability to add/remove stream admins, but I think that can wait.

There is one more permission: make private stream public.
Only the stream admin and any admins subscribed to the stream can do that.
In the case where there are no such people: we should recommend the following workaround on the stream settings page: "add an admin, the admin can make the stream public, and then the admin can unsubscribe".

@gioragutt
Copy link

Hey guys, any update on this? I really like zulip and this point is really critical for me and the organization.

@rishig
Copy link
Member

rishig commented Jun 24, 2018

Thanks for writing in!
The majority of the work for this has been done and merged: https://chat.zulip.org/help/stream-permissions.

Is there a part of this on top of the work that has been done that is still critical?

@gioragutt
Copy link

@rishig Hey, I'm currently using the docker-zulip repo that does not have this feature yet. It sits on version 1.8.1-0. In what version was the feature merged?

Also, thanks for the quick reply!

@KirillKhrushkov
Copy link

Also it would be nice to implement functionality of adding/changing Stream Owners.
Organisation admin or Stream owner should be able to:

  1. add any stream subscriber to Stream Owner role
  2. delete anyone from Stream Owner role

But this is next step. The most important functionality is described at post above.

Thank you!

@decaz
Copy link

decaz commented Jan 30, 2019

It's very important to add such stream privacy setting for "stream membership" so that either any member or stream owner only can invite users to stream.

@rishig
Copy link
Member

rishig commented Jan 30, 2019

@KirillKhrushkov got it, thanks!
@decaz we already offer this: https://zulipchat.com/help/stream-permissions

@decaz
Copy link

decaz commented Jan 30, 2019

@rishig isn't any of the members of the stream can invite someone else to stream?

@rishig
Copy link
Member

rishig commented Jan 30, 2019

ah, I misunderstood your suggestion. You'd like to (have the option to) limit invites to the stream owner?

@decaz
Copy link

decaz commented Jan 30, 2019

@rishig exactly! I think it's the main point of stream privacy.

@KirillKhrushkov
Copy link

Just one more thing.
Stream Owner should be able to change topic of messages anytime inside the stream as it is allowed for admins now.

@KirillKhrushkov
Copy link

Hi Team!
Could you please say if there are any news on this topic?
Thank you

@laem
Copy link

laem commented Apr 17, 2019

Being able as a member to create a stream but not rename it is disturbing.

@amartin3225
Copy link

Would this configuration for stream permissions provide an option to only allow the stream admin(s) to invite new users to the stream? I could see that as being a problem in large private streams - currently any member can invite new users which may be undesirable; if instead inviting new users was restricted to the stream admins, that would provide better management of stream membership

@timabbott
Copy link
Sponsor Member

I expect that once we have a stream owner concept, there's a bunch of features we'll be transitioning to be doable by the stream owner. I expect @YJDave will be building the core model for this in the next few weeks.

@gameglz
Copy link

gameglz commented Sep 6, 2019

Is it possible to add more roles to the organization ? such as staff members or mods. and have their roles displayed in the realm user list ?

@timabbott
Copy link
Sponsor Member

@gameglz it's certainly possible to do so with a significant fork, but we don't have a system for adding those inexpensively. What do you have in mind?

@gameglz
Copy link

gameglz commented Sep 14, 2019

it's certainly possible to do so with a significant fork, but we don't have a system for adding those inexpensively. What do you have in mind?

@timabbott
Like more roles that can be displayed in the server for different users or if this is customizable that would be even better. Sometimes we have lead staffs/support staffs or even team project managers in the server but we cant give them a roll or any recognition due to the lack of roles and authorities...
It seems very awkward when new people join in and dont know whos who..
Also theres another major issue I found during my 1st week of hosting my own server.
There needs to be an option for authority to creating topics... Because I find that sometimes its very messy when everyone could create topics under a stream. I server has over 200 members including staffs and just normal users. It gets very frustrating sometimes when i wake up seeing 50+ topics with just random titles....liek 1111, =, 。, etc... I just think there must be a better way to organize this

@KirillKhrushkov
Copy link

Hi Team!
Do you have any update on Stream Owner feature?

@Garagoth
Copy link

Hi!
What would be required to implement this?
It seems that once stream is created it cannot be edited by ordianry member, admins can change name, description and unsubscribe people. It is also possible to unsubscribe everyone with no option to subscribe again (except for manage.py commands).
Most other platforms offer concepts of member, moderator (threads creation and/or removal), stream owner (full control over stream), admin (as it is) and I am in need of those extra permissions.
I am willing to look into implementation but I would need some hints where is the necessary logic.

@nanohayder
Copy link

Hi,
any update on this? it would greatly help us

@timabbott
Copy link
Sponsor Member

This is being worked on currently. We're hoping it'll make the 2.2 release, but it's a fairly complex change to the permissions model that will need a lot of care, so no promises.

The current workaround in 2.1.x is to add an organization administrator to a stream temporarily, but I agree it's not great.

@Gittenburg Gittenburg added new feature A proposed new feature for the product and removed enhancement labels Jul 10, 2020
@pint-pint
Copy link

This is being worked on currently. We're hoping it'll make the 2.2 release, but it's a fairly complex change to the permissions model that will need a lot of care, so no promises.

The current workaround in 2.1.x is to add an organization administrator to a stream temporarily, but I agree it's not great.

What is the current status of this, has this dream been abandoned or is it still considered? As long as there are private streams, there should be a way for some user(s) to admin the stream without organization level admin privileges.

@Garagoth
Copy link

@timabbott You mentioned that this is being implemented and targeted for 2.2, that version was newer released (2.1.7 went straight to 3.0). What is the state of this feature, and if it was abandoned, could you please outline what needs to be done here (as you already worked on this, to not re-do same work)?

@pint-pint
Copy link

Has there been any progress with this? Snipping users out of streams burdens admins and is inconvenient for users who have to request the removals.

@Garagoth
Copy link

Garagoth commented Apr 1, 2021

I think there is ongoing work for this in PR #15334 and also supplementary work in #12016, if anyone is looking for progress updates :-)

@Garagoth
Copy link

Oh no. I was really hoping for it to be included in 4.0 release.
Is there any hope for this feature?

@timabbott
Copy link
Sponsor Member

I've written up our technical plan for this area, which is now tracked at #19525. I expect that work to be the main project for multiple core team members for the next few months; if we're lucky it'll make the 5.0 release cycle.

I think it makes sense to close this ancient given those plans, since the precise design described here is much less flexible and the plan in #19525 will cover everything imagined here and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests