bugdown: Buggy local echo when ending with at-mention.

[rishig]

Not sure what the underlying issue is, but a reproducer is

stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff stuff 
<@mention someone>

The local echo should have 15 copies of the @mention replacing all the stuff.

[zulipbot]

Hello @zulip/server-markdown members, this issue was labeled with the area: markdown label, so you may want to check it out!

[mahimg]

As far as I got, this happens whenever @mention starts in a new line with some content before it. Most probably there is some error in regex, will follow up tomorrow.

[mahimg]

@zulipbot claim

[zulipbot]

Congratulations, @mahimg, you've successfully claimed your first issue! Since you're a new contributor, you now have pull (read-only) access to this repository.

Please review our code contribution guidelines and sign the Dropbox Contributor License Agreement before opening any pull requests for any issues that you're working on.

Also, if you haven't done so already, please join us on the Zulip development server at chat.zulip.org! Our community of developers use chat.zulip.org as our primary communication forum for developing Zulip; you can read more about the chat.zulip.org community in our documentation.

Note: Depending on your notification settings, granting you the permission in GitHub's model that allows you to be assigned issues by zulipbot may result in making you a "watcher" on this repository, which means that you'll get notifications for every issue and pull request in this repository; for a large repository like zulip/zulip, that means receiving over 100 emails per day. If you don't want to receive notifications unless you're actually involved with the issue (which is usually the right choice for large projects), you should unwatch this repository.

[rishig]

Great, thanks @mahimg!

[zulipbot]

Hello @mahimg, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for a week. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @zulipbot abandon so that someone else can claim it and continue from where you left off.

Thank you for your valuable contributions to Zulip!

[mahimg]

@zulipbot I am working on this.

[zulipbot]

Hello @mahimg, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over ten days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

[Akyya-Mayberry]

@zulipbot claim

[Akyya-Mayberry]

It seems that in marked.js the Parser.parse static method throws off the local echo. I realized that when it is called from the marked function, if you explicitly pass in the renderer arg as opt.userMentionHandler, than the markup is more accurate. I will have to look into the original implementation of the marked.js and see how this works. I am not sure if that arg is required for the static method and how the opts/options are used in this.

[lonerz]

Should be fixed in ec669a0