Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-duplicate admin-realm-form. #4485

Closed
showell opened this issue Apr 12, 2017 · 3 comments
Closed

De-duplicate admin-realm-form. #4485

showell opened this issue Apr 12, 2017 · 3 comments
Labels
area: settings (admin/org)

Comments

@showell
Copy link
Contributor

showell commented Apr 12, 2017

We have two different forms called admin-realm-form. We should split this up into two separate forms and two separate click handlers, where each click handler only sends the data from its particular form.

Do not claim this until #4462 gets merged, please.
@zulipbot
Copy link
Member

Hello @zulip/server-settings members, this issue was labeled with the area: settings (admin/org) label, so you may want to check it out!

@showell
Copy link
Contributor Author

showell commented Apr 13, 2017

#4462 has been merged, so somebody can claim this now.

@timabbott
Copy link
Sponsor Member

@showell I think this one might have been resolved; can you confirm? It seems like we changed it from an ID to a class, and it's no longer used in click handlers....

@showell showell closed this as completed Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: settings (admin/org)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@showell @timabbott @zulipbot