Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make current single user invite system use the backend of multi use invite link #6745

Open
hackerkid opened this issue Sep 28, 2017 · 6 comments

Comments

@hackerkid
Copy link
Member

hackerkid commented Sep 28, 2017

We should probably convert the existing invitation system to use the same "show registration form" model used by multi use invite link. Current implementation sends the verification email directly to the invited user which means the invited user won't be able to choose an email of his choice for signing up. You should be able to tweak multi use invite link flow to implement single user invite link.

screenshot from 2017-09-28 14-31-08

If you are not familiar with multi_use invite link run ./manage.py generate_multiuse_invite_link and play around it a bit.

Discuss how you are going to tweak multi_use invite flow to implement this in chat.zulip.org before starting work.

@zulipbot
Copy link
Member

Hello @zulip/server-onboarding members, this issue was labeled with the area: onboarding label, so you may want to check it out!

@hackerkid
Copy link
Member Author

@zulipbot claim

@zulipbot
Copy link
Member

zulipbot commented Oct 7, 2017

Hello @hackerkid, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 10 days.

You can reclaim this issue or claim any other issue by commenting @zulipbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

@mrchntia
Copy link
Collaborator

@hackerkid, @timabbott is this still a desired change? If yes, I would like to work on this.

To clarify: If a user is invited to join an organization via a singel user invite they should also be able to choose the email for sign up like it is the case for multi user invite. Is that correct?

@hackerkid
Copy link
Member Author

To clarify: If a user is invited to join an organization via a singel user invite they should also be able to choose the email for sign up like it is the case for multi user invite. Is that correct?

Yes. The user who is invited should be able to choose the email as well as have the ability to sign in with a SSO like Google. I would also recommend searching for relevant conversations in chat.zulip.org for more context.

https://chat.zulip.org/#narrow/stream/49-development-help/topic/User.20Invite is one of them.

#6326 is another related issue.

@mrchntia
Copy link
Collaborator

mrchntia commented Feb 4, 2021

It seems to be unclear if this is desired in the first place and it's definitly not a priority, so I'll search for an other issue to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants