Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for "@tabbott" should typeahead to some sort of mentions:email syntax #6902

Open
timabbott opened this issue Oct 7, 2017 · 7 comments

Comments

@timabbott
Copy link
Sponsor Member

It'd be nice to be able to search my messages for things that directly mention another user.

I think it'd be not too hard to accomplish, at least moderately well, by just search that other user's UserMessage table, and then filtering for UserMessage rows on YOUR UserMessage table. But that has some messy security implications to think about, and will also not cover cases where that user was mentioned but not subscribed, which we possibly do want to fetch.

So the best idea I have for how the backend should work is using full-text search to find the appropriate mention markup.

@zulipbot
Copy link
Member

zulipbot commented Oct 7, 2017

Hello @zulip/server-search members, this issue was labeled with the area: search label, so you may want to check it out!

@SatyendraBanjare
Copy link
Collaborator

SatyendraBanjare commented Jan 18, 2018

Shouldn't there also be a max limit of result queries of latest 5/10 messages...?? and we can force stop search if 5 successful results are achieved, anyway I think I can work on this issue.
@timabbott @rishig

@zulipbot claim

@zulipbot
Copy link
Member

ERROR: Unexpected response from GitHub API.

@SatyendraBanjare
Copy link
Collaborator

@zulipbot claim --force

@zulipbot
Copy link
Member

ERROR: Unexpected response from GitHub API.

@SatyendraBanjare
Copy link
Collaborator

Hi @rishig Please assign me to this. I want to work on this.

@zulipbot
Copy link
Member

Hello @SatyendraBanjare, it looks like you've currently claimed 1 issue in this repository. We encourage new contributors to focus their efforts on at most 1 issue at a time, so please complete your work on your other claimed issues before trying to claim this issue again.

We look forward to your valuable contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants