Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node tests: Remove crufty fakes/mocks. #9443

Open
showell opened this issue May 17, 2018 · 1 comment
Open

node tests: Remove crufty fakes/mocks. #9443

showell opened this issue May 17, 2018 · 1 comment

Comments

@showell
Copy link
Contributor

showell commented May 17, 2018

It's easy to run the node coverage reports and track down code in the tests themselves that never gets called. Usually these are fakes/mocks that aren't really needed any more to test the code.

We should probably come up with a scheme to lock down these files, too, although there are some nuisances, like it's often legit to have a little bit of dead code in the node tests to help troubleshoot things like switch reaching default.

@zulipbot
Copy link
Member

Hello @zulip/server-testing members, this issue was labeled with the "area: testing-coverage" label, so you may want to check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants