Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing sentences with "/me" doesn't re-render the result #163

Closed
itamarst opened this issue Oct 8, 2015 · 3 comments
Closed

Editing sentences with "/me" doesn't re-render the result #163

itamarst opened this issue Oct 8, 2015 · 3 comments
Labels
bug good first issue help wanted

Comments

@itamarst
Copy link

itamarst commented Oct 8, 2015

I typed in:

/me nosd

Edited that to

/me nods

But it still rendered as original way, and the "EDITED" bit showed up funny.

Using Firefox.
@lfaraone lfaraone added the bug label Oct 8, 2015
@timabbott
Copy link
Sponsor Member

Reproduced. This is a frontend bug -- if you reload is renders properly.

The issue is that the frontend is I think not correctly rerendering /me messages after they are edited.

This seems like it could be a good starter bug for someone interested in getting involved.

@cnguye11
Copy link

I can work on this!

@cnguye11 cnguye11 mentioned this issue Oct 24, 2015
Closed
cnguye11 added a commit to cnguye11/zulip that referenced this issue Oct 25, 2015
@cnguye11
Rerender and build_message both format /me messages. Fixes zulip#163
c280fce
@elsander elsander mentioned this issue May 25, 2016
Closed
@timabbott timabbott mentioned this issue May 29, 2016
Closed
@timabbott
Copy link
Sponsor Member

This was fixed in #848, but #835 and #836 are still open.

@timabbott timabbott mentioned this issue May 31, 2016
Closed
TomaszKolek pushed a commit to TomaszKolek/zulip that referenced this issue Jul 6, 2016
Refresh page when message with /me is edited.
47dc48e 
Fixes: zulip#163.

Thanks to Catherine Nguyen (@cnguye11) for her work on this.
TomaszKolek pushed a commit to TomaszKolek/zulip that referenced this issue Aug 25, 2016
Refresh page when message with /me is edited.
3eab3cb 
Fixes: zulip#163.

Thanks to Catherine Nguyen (@cnguye11) for her work on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lfaraone @timabbott @itamarst @cnguye11