Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding install instructions for zinit to the readme #122

Closed
wants to merge 1 commit into from

Conversation

ryaminal
Copy link

@ryaminal ryaminal commented Sep 8, 2021

Simple PR with zinit instructions.

I attempted to get the autocomplete working with zinit but failed... Thought this was still valuable, though.

@vladdoster
Copy link

vladdoster commented Dec 31, 2022

@ryaminal

Zinit has an actively maintained fork. I renamed the completion file so zinit will automatically install it. Additionally, it has a few other QoL improvements.

Screenshot 2022-12-31 at 14 40 00

See the README installation instructions

zdharma-continuum/zunit

@ryaminal
Copy link
Author

Huh, they do have a fork there. fascinating. Wonder why.
Guess it's time to close this PR. It's been hanging out here for a few years, long before the great upheaval in the zdharma/zinit ecosystem.

@ryaminal ryaminal closed this Mar 14, 2023
@vladdoster
Copy link

vladdoster commented Mar 18, 2023

@ryaminal,

I created the fork and made all the changes, so here is some context.

  1. Rename the completion file to _zunit to automatically get picked up by Zinit. See commit.

  2. Change the log messages to make grokking test results easier.

Screenshot 2023-03-18 at 12 42 31

  1. Add new assertions specific to Zinit.

  2. Make molovo/revolver an optional dependency because it added a ton of noise (thousands of lines) to the Github Action log output.

There are a few more things, but those are the four main reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants