Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.0 without "Added BankAccount to allowed type in PaymentMethod" #15

Merged
merged 31 commits into from Dec 10, 2013
Merged

Version 1.0 without "Added BankAccount to allowed type in PaymentMethod" #15

merged 31 commits into from Dec 10, 2013

Conversation

Bram--
Copy link
Contributor

@Bram-- Bram-- commented Dec 10, 2013

#14

jmoline and others added 30 commits June 18, 2012 09:18
@jmoline
support multiple product rate plans in subscribe requests
a9a6e32
@jmoline
adding method for backward compatibility of single product_rate_plan …
f2392a7 
…in subreq
@jmoline
product_rate_plan= method shouldn't be protected
4e66f55
@jmoline
DRYing object xml generation methods
b8b2d1f
@jmoline
specs to cover modifications to validation methods and turning produc…
b08ebaf 
…t_rate_plan into product_rate_plans
Update dependencies - inspired by and heavily lifted from @mdemin914
40ca7e2
@nirvdrum
As it turns out, some months have 31 days.
1122cc4
@nirvdrum
Set the account_id value after successfull subscribing.
df90fd2
@nirvdrum
account_id isn't always required. It may be blank for :subscribe calls.
d02820d
@nirvdrum
Allow passing just the product_rate_plan_id rather than a fully mater…
eb66903 
…ialized object when creating a SubscribeRequest.
Updated @nirvdrum spec to support new return values
fd51194
Revert "Updated @nirvdrum spec to support new return values"
d4e9af6 
This reverts commit fd51194.
Revert "Allow passing just the product_rate_plan_id rather than a ful…
63f9ef8 
…ly materialized object when creating a SubscribeRequest."

This reverts commit eb66903.
Merge remote-tracking branch 'jmoline/multiple_rate_plans' into 1.0
0f59b53 
Support multiple rate plans in a subscription request.

Conflicts:
	lib/zuora/objects/subscribe_request.rb
@jmoline @Bram--
support multiple product rate plans in subscribe requests
a46b0dc
@jmoline @Bram--
adding method for backward compatibility of single product_rate_plan …
6ef6b00 
…in subreq
@jmoline @Bram--
product_rate_plan= method shouldn't be protected
6f37596
@jmoline @Bram--
DRYing object xml generation methods
b7faf09
@jmoline @Bram--
specs to cover modifications to validation methods and turning produc…
5ec27e5 
…t_rate_plan into product_rate_plans
@Bram--
Update dependencies - inspired by and heavily lifted from @mdemin914
c3eca59 
Conflicts:
	lib/zuora/objects/subscribe_request.rb
@nirvdrum @Bram--
As it turns out, some months have 31 days.
b353b0f
@nirvdrum @Bram--
Set the account_id value after successfull subscribing.
ee7b42a
@nirvdrum @Bram--
account_id isn't always required. It may be blank for :subscribe calls.
2d0bdee
@nirvdrum @Bram--
Allow passing just the product_rate_plan_id rather than a fully mater…
fb51b3b 
…ialized object when creating a SubscribeRequest.
@Bram--
Updated @nirvdrum spec to support new return values
8fc1d4c
@Bram--
Revert "Updated @nirvdrum spec to support new return values"
8b97f32 
This reverts commit fd51194.
@Bram--
Revert "Allow passing just the product_rate_plan_id rather than a ful…
8d3eb3e 
…ly materialized object when creating a SubscribeRequest."

This reverts commit eb66903.
@Bram--
Merge commit '0f59b53' into v1.0
b969579 
Conflicts:
	lib/zuora/objects/subscribe_request.rb
@nirvdrum @Bram--
Implemented the :amend call.
5886a88 
merged from backupify/zuora

Conflicts:
	lib/zuora/soap_connector.rb
@Bram--
Add jmonline to contributor list and fix a typo
6ed98a5
@Bram-- Bram-- mentioned this pull request Dec 10, 2013
Closed
Bram-- added a commit that referenced this pull request Dec 10, 2013
@Bram--
Merge pull request #15 from wildfireapp/v1.0
8666679 
Version 1.0 without "Added BankAccount to allowed type in PaymentMethod"
@Bram-- Bram-- merged commit 8666679 into master Dec 10, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Bram-- @jmoline @nirvdrum