Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Charles is not paginating on docker hub registry integration when the number of tags in registry is greater than 100 #169

Closed
emiteze opened this issue Jun 25, 2020 · 2 comments
Assignees
Labels
bug Something isn't working moove Improvements/additions/fixes for moove module. severity/moderate ui Improvements/additions/fixes for ui module. villager Improvements/additions/fixes for villager module.

Comments

@emiteze
Copy link
Contributor

emiteze commented Jun 25, 2020

Describe the bug
Today we only search for the first 100 tags ordered by name on user's Docker Registry.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new registry configuration and register a new module that have more than 100 tags.
  2. Try to search for your tags on the override release screen on any circle.
  3. Note that only the first 100 tags are being returned.

Expected behavior
We should have pagination on backend for this service.

@emiteze emiteze added bug Something isn't working villager Improvements/additions/fixes for villager module. moove Improvements/additions/fixes for moove module. labels Jun 25, 2020
@adauto
Copy link
Contributor

adauto commented Jul 3, 2020

#241

@adauto adauto added the ui Improvements/additions/fixes for ui module. label Jul 5, 2020
@adauto
Copy link
Contributor

adauto commented Jul 8, 2020

Docker registry's V2 REST API does not offer a way to query image tags by its name, so we decide to remove the current fake pagination that frontend performs and we will ask users to inform the tag full name to check if it exists or not. #241

@adauto adauto changed the title Charles is not paginating on docker hub registry integration Charles is not paginating on docker hub registry integration when the number of tags in registry is greater than 100 Jul 8, 2020
@adauto adauto closed this as completed Jul 10, 2020
Bugs, stability and improvement automation moved this from High priority to Closed Jul 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working moove Improvements/additions/fixes for moove module. severity/moderate ui Improvements/additions/fixes for ui module. villager Improvements/additions/fixes for villager module.
Development

No branches or pull requests

4 participants