Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

QueuedIstioDeployment table is unnecessary inside butler #207

Closed
lucasbfernandes opened this issue Jun 30, 2020 · 1 comment
Closed

QueuedIstioDeployment table is unnecessary inside butler #207

lucasbfernandes opened this issue Jun 30, 2020 · 1 comment
Labels
butler Improvements/additions/fixes for butler module.

Comments

@lucasbfernandes
Copy link
Contributor

Describe the solution you'd like
Since it is necessary that all components' deployments are finished before the virtual service deployment is triggered, it is correct to assume that all QueuedDeployment entities associated are set to RUNNING, therefore assuring that any deployment requests on those components will be forced to wait.

If all deployment requests for those components will have to wait, we could just query the deployment and trigger all components associated with it.

PS: Today the QueuedIstioDeployment entity doesn't even act like a queue
@lucasbfernandes lucasbfernandes added the butler Improvements/additions/fixes for butler module. label Jun 30, 2020
@lucasbfernandes
Copy link
Contributor Author

#478 fixes this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
butler Improvements/additions/fixes for butler module.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucasbfernandes