Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

Butler v2 #478

Closed
wants to merge 33 commits into from
Closed

Butler v2 #478

wants to merge 33 commits into from

Conversation

lucasbfernandes
Copy link
Contributor

Signed-off-by: Lucas Borges Fernandes lucasbfernandes94@gmail.com

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
@boring-cyborg boring-cyborg bot added the butler Improvements/additions/fixes for butler module. label Sep 11, 2020
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #478 into master will increase coverage by 1.25%.
The diff coverage is 85.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #478      +/-   ##
============================================
+ Coverage     66.60%   67.86%   +1.25%     
  Complexity     1644     1644              
============================================
  Files          1125     1180      +55     
  Lines         16501    17650    +1149     
  Branches       1412     1549     +137     
============================================
+ Hits          10991    11978     +987     
- Misses         5041     5203     +162     
  Partials        469      469              
Flag Coverage Δ Complexity Δ
#butler 86.77% <85.42%> (-0.55%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
.../src/app/v1/api/components/pipe/components.pipe.ts 66.66% <0.00%> (ø) 0.00 <0.00> (ø)
...figurations/pipes/valid-configuration-data.pipe.ts 18.18% <0.00%> (ø) 0.00 <0.00> (ø)
...naker/connector/pipelines/create-total-pipeline.ts 91.75% <ø> (ø) 0.00 <0.00> (ø)
...1/core/integrations/databases/databases.service.ts 100.00% <ø> (ø) 0.00 <0.00> (ø)
...src/app/v2/core/integrations/octopipe/connector.ts 25.92% <25.92%> (ø) 0.00 <0.00> (?)
...app/v1/core/integrations/cd/cd-strategy.factory.ts 72.22% <28.57%> (ø) 0.00 <0.00> (ø)
...ployments/use-cases/create-undeployment.usecase.ts 46.87% <46.87%> (ø) 0.00 <0.00> (?)
...integrations/cd/spinnaker/spinnaker-api.service.ts 86.66% <50.00%> (+66.66%) 0.00 <0.00> (ø)
.../app/v2/core/integrations/octopipe/octopipe-api.ts 55.55% <55.55%> (ø) 0.00 <0.00> (?)
.../core/integrations/cd/octopipe/octopipe.service.ts 86.66% <66.66%> (ø) 0.00 <0.00> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8257d42...9896918. Read the comment docs.

@cpgo cpgo mentioned this pull request Sep 14, 2020
6 tasks
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* add transaction to notification use case

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* set moduleId field as optional on deployment creation

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
lucasbfernandes and others added 2 commits October 5, 2020 14:07
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
cpgo and others added 6 commits October 7, 2020 11:14
* check execution on simultaneous-deployment pipe

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* use enum on query value

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* Octopipe v2 integration structure

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Deployment complete flow

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Proxy deployments stage

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Rollback flow

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Complete deployment pipeline

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Undeployment flow

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Logging everything

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Fix async stuff

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* fix proxy deployments

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Using force update

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* remove forceUpdate option

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Removing unnecessary parameters

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Fix override empty array

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* initial changes

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* creating connector

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* octopipe integration structure

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* undeployment object

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Fixing minor errors

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Removing unnecessary space

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Delete unused deployments

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* fix integration problems

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Add deployment uniqueness validation

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* octopipe deployment tests initial structure

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Octopipe request builder tests (deployment)

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* octopipe undeployment tests

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Cluster config tests

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* use typeorm update instead of save on receive notification update

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* remove console.log

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
@cpgo cpgo added the ui Improvements/additions/fixes for ui module. label Oct 14, 2020
lucasbfernandes and others added 9 commits October 14, 2020 15:32
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
The save method may try to insert a new record or
perform an update, in this case we only want to update and error out if no deployment is found

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* UI: save empty string instead of unmatched

Butler: validate empty string and uuid
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* Fix x-circle-id validation

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* fix ui x-circle-id handling

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* add semicolon

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

Co-authored-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
* Octopipe v2 integration structure

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Deployment complete flow

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Proxy deployments stage

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Rollback flow

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Complete deployment pipeline

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Undeployment flow

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Logging everything

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Fix async stuff

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* fix proxy deployments

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Using force update

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* remove forceUpdate option

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Removing unnecessary parameters

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Fix override empty array

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* init

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* compose working

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* update compose

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* create namespaces

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* initial changes

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* adding octopipe container

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* using OUT OF CLUSTER mode

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* remove unused stuff from k3s

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* creating connector

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* local docker registry

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* octopipe integration structure

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* undeployment object

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Fixing minor errors

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Removing unnecessary space

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* Delete unused deployments

Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>

* working github mock server

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

* add overrides to start script to run butler

Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>

Co-authored-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
butler Improvements/additions/fixes for butler module. TESTED QA ui Improvements/additions/fixes for ui module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants