This repository has been archived by the owner on Jul 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
butler
Improvements/additions/fixes for butler module.
label
Sep 11, 2020
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #478 +/- ##
============================================
+ Coverage 66.60% 67.86% +1.25%
Complexity 1644 1644
============================================
Files 1125 1180 +55
Lines 16501 17650 +1149
Branches 1412 1549 +137
============================================
+ Hits 10991 11978 +987
- Misses 5041 5203 +162
Partials 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* add transaction to notification use case Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * set moduleId field as optional on deployment creation Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
thallesfreitaszup
suggested changes
Sep 16, 2020
butler/src/app/v2/api/deployments/dto/execution/paginated-execution-query.dto.ts
Show resolved
Hide resolved
butler/src/app/v2/api/deployments/dto/execution/paginated-executions.dto.ts
Show resolved
Hide resolved
butler/src/app/v2/core/integrations/spinnaker/templates/undeployment/index.ts
Show resolved
Hide resolved
butler/src/app/v2/core/integrations/spinnaker/utils/common-template.utils.ts
Show resolved
Hide resolved
butler/src/app/v2/core/integrations/spinnaker/utils/deployment-template.utils.ts
Show resolved
Hide resolved
butler/src/app/v2/core/integrations/spinnaker/utils/undeployment-template.utils.ts
Show resolved
Hide resolved
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
thallesfreitaszup
previously approved these changes
Sep 23, 2020
This was referenced Sep 29, 2020
QueuedDeployment status should be set to FINISHED only when virtual service deployment finishes
#206
Closed
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* check execution on simultaneous-deployment pipe Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * use enum on query value Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* Octopipe v2 integration structure Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Deployment complete flow Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Proxy deployments stage Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Rollback flow Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Complete deployment pipeline Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Undeployment flow Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Logging everything Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Fix async stuff Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * fix proxy deployments Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Using force update Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * remove forceUpdate option Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Removing unnecessary parameters Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Fix override empty array Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * initial changes Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * creating connector Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * octopipe integration structure Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * undeployment object Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Fixing minor errors Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Removing unnecessary space Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Delete unused deployments Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * fix integration problems Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Add deployment uniqueness validation Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * octopipe deployment tests initial structure Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Octopipe request builder tests (deployment) Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * octopipe undeployment tests Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Cluster config tests Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* use typeorm update instead of save on receive notification update Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * remove console.log Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
The save method may try to insert a new record or perform an update, in this case we only want to update and error out if no deployment is found Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com>
* UI: save empty string instead of unmatched Butler: validate empty string and uuid Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * Fix x-circle-id validation Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * fix ui x-circle-id handling Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * add semicolon Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> Co-authored-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
* Octopipe v2 integration structure Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Deployment complete flow Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Proxy deployments stage Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Rollback flow Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Complete deployment pipeline Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Undeployment flow Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Logging everything Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Fix async stuff Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * fix proxy deployments Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Using force update Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * remove forceUpdate option Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Removing unnecessary parameters Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Fix override empty array Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * init Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * compose working Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * update compose Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * create namespaces Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * initial changes Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * adding octopipe container Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * using OUT OF CLUSTER mode Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * remove unused stuff from k3s Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * creating connector Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * local docker registry Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * octopipe integration structure Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * undeployment object Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Fixing minor errors Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Removing unnecessary space Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * Delete unused deployments Signed-off-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com> * working github mock server Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> * add overrides to start script to run butler Signed-off-by: Cassio Godinho <cassiopgodinho@gmail.com> Co-authored-by: Lucas Borges Fernandes <lucasbfernandes94@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lucas Borges Fernandes lucasbfernandes94@gmail.com