Add gpt-4-1106-preview model #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thanks for the PR! Linking to the docs here. This tiktoken-rs module doesn't depend on the python code. To get around that, we rewrote some of the wrapping python logic in rust for consistency. |
JosephTLyons
added a commit
to zed-industries/zed
that referenced
this pull request
Nov 14, 2023
The PR to add the `gpt-4-1106-preview` model was merged: zurawiki/tiktoken-rs#49
|
Awesome - Thanks for the info and for accepting the PR! |
JosephTLyons
added a commit
to zed-industries/zed
that referenced
this pull request
Nov 14, 2023
This PR adds the `gpt-4-1106-preview` model. It required forking two repos from different organizations, as one is a submodule of another. Update 1: ~Currently, I'm just temporarily pointing towards a personal fork of the repo, but once [this PR](zurawiki/tiktoken-rs#49) lands, we can switch back to using the official crate.~ Update 2: ~PR was merged, we are now pointing to a specific commit on the original official repo - may want to bump it to an official version once a new one has been released.~ Update 3: Author published a [new version](https://crates.io/crates/tiktoken-rs/0.5.7). Now, we are back to relying on the official crate. <img width="1118" alt="SCR-20231114-ibgs" src="https://github.com/zed-industries/zed/assets/19867440/cc2657b6-98f9-413f-9a0c-f337636f367c"> Release Notes: - Added support for the [`gpt-4-1106-preview`](https://openai.com/blog/new-models-and-developer-products-announced-at-devday) model in the assistant panel. - Updated the `assistant.default_open_ai_model` setting to default to `gpt-4-1106-preview`. To override the default, use the following snippet to your `settings.json` file: ```rs "assistant": { // 1. "gpt-3.5-turbo-0613"" // 2. "gpt-4-0613"" // 3. "gpt-4-1106-preview" "default_open_ai_model": "<Your choice of model here>" }, ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure if anything else here is needed. I opened a PR to the tiktoken submodule here - assuming that might need to be merged in first before this one could be considered?