$digest/$apply already in progress

[maxcook]

$apply already in progress
This error occurs on multiple js components. $apply() always needs a if (!scope.$root.$$phase) {.
Currently this check is only applied to the $apply in the notification.js. However it is always required since the Foundation API gets mostly called from angular controllers, so digest is usually already in progress.

foundation-apps/js/angular/components/notification/notification.js

Line 189 in 23fee87

scope.$apply();

foundation-apps/js/angular/components/modal/modal.js

Line 56 in adc5960

scope.$apply();

and many more require
if (!scope.$root.$$phase) {

[AntJanus]

I'll be adding these to all the pertinent directives as I build factories for them.

[AntJanus]

It's been added to notification and modal. We'll add it as needed. I'll close this out.

[etcook]

@AntJanus I'm getting this error when trying to open and close a panel.

[etcook]

@AntJanus I'm consistently getting this error when I use

FoundationApi.publish('id', 'show');

Is there a workaround in the interim that I can use to squelch the errors?

Edit: It's a panel.

[etcook]

@AntJanus Any update on this? I'm really sorry to keep bothering you.

[AntJanus]

@etcook I'm currently off the project. I'll go ahead and reopen this issue for someone to check up on this.

[jamieshark]

Hey @etcook , I went ahead and added the additional conditional checks. This error is no longer showing up for me, but let me know if it still persists for you.

[ProLoser]

@jeanieshark @AntJanus this is now how you fix this sort of bug. You are fixing symptoms instead of problems.

You should hoist the $scope.$apply() to the top of the stack trace.