-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media queries for reveal #4780
Comments
@pepebe Thanks for bringing this up. This is a well known issue with sass. sass/sass#316 and sass/sass#116 Currently using media queries through variables in sass will lead to multiple declarations of the same media query. Ideally you would want all of the media rules to be clustered into a single query. However, if the files are minified and gzipped, this might be a non-issue as gzipping identifies recurring patterns and compresses them. If you're still interested, you might want to check out https://github.com/aaronjensen/sass-media_query_combiner |
Apologies, I just noticed the multiple min widths...Will take a look into this |
Thanks. As they are now, the measures are completely broken but I guess nobody will notice for a long time as the basic functionality is not compromised. Take your time ;) |
It appears to be coming from this line, which wraps the classes, since the |
yeah, was this line. Added in haste at one point and has now been removed for 5.3.2 Cheers all! |
Just noticed that lines 3454+ in foundations.css inv.5.2.1 look fishy...
Identical min-width rules in each mediaquery (min vs. min) as well as the same rules for several of them in a row.
I don't have the time right now to do more research and before I forget to do anything, I think its better to at least post this here.
Regards,
pepebe
The text was updated successfully, but these errors were encountered: