chore: update docs styles when SCSS change #11491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation styles uses the SCSS mixins/functions, so they must be recompiled when the SCSS change. Introduced in foundation#11454
IamManchanda
reviewed
Sep 9, 2018
| @@ -27,7 +27,7 @@ gulp.task('serve', gulp.series('build', function(done){ | |||
| gulp.task('watch', function() { | |||
| gulp.watch('docs/**/*', gulp.series('docs', browserReloadSync)); | |||
| gulp.watch(['docs/layout/*.html', 'docs/partials/*{html,hbs}', 'docs/assets/partials/*{html,hbs}', 'node_modules/foundation-docs/templates/*{html,hbs}'], gulp.series('docs:all', browserReloadSync)); | |||
| gulp.watch('scss/**/*', gulp.series('sass:foundation', browserReloadSync)); | |||
| gulp.watch('scss/**/*', gulp.series('sass', browserReloadSync)); | |||
There was a problem hiding this comment.
The Task Runner PR Looks good to me!
https://github.com/zurb/foundation-sites/blob/f74c6f7dba5e9c4c57e48318d4e1631ede4f6f90/gulp/tasks/sass.js#L17
IamManchanda
approved these changes
Sep 9, 2018
|
Thank you for your review @IamManchanda, and welcome back! 🎉 Feels free to take a look at the latest pull requests, and those with the needs reviewers label. |
ncoden
added a commit
to ncoden/foundation-sites
that referenced
this pull request
Sep 10, 2018
…ch for v6.5.0 f74c6f7 chore: update docs styles when SCSS change Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Documentation styles uses the SCSS mixins/functions, so they must be recompiled when the SCSS change. This pull request start the Gulp task
sasswhich contains bothsass:foundationandsass:docswhen the scss change.Types of changes
Checklist
developordevelop-v...).I have updated the documentation accordingly to my changes (if relevant).I have added tests to cover my changes (if relevant).