Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup #11562

Merged
merged 1 commit into from
Oct 26, 2018
Merged

cleanup #11562

merged 1 commit into from
Oct 26, 2018

Conversation

xeptore
Copy link
Contributor

@xeptore xeptore commented Oct 26, 2018 •
edited
Loading

guess that was an unnecessary (broken!) span element and official doc does not apply any highlighting on that block of code

Types of changes

  • Documentation
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (anything that would change an existing functionality)
  • Maintenance (refactor, code cleaning, development tools...)

Checklist

  • I have read and follow the CONTRIBUTING.md document.
  • The pull request title and template are correctly filled.
  • The pull request targets the right branch (develop or develop-v...).
  • My commits are correctly titled and contain all relevant information.
  • I have updated the documentation accordingly to my changes (if relevant).
  • I have added tests to cover my changes (if relevant).

@xeptore
cleanup
66adaa1 
i guess that was an unnecessary (broken!) span element and official doc does not apply any highlighting on that block of code
@ncoden ncoden merged commit 416094d into foundation:develop Oct 26, 2018
ncoden pushed a commit that referenced this pull request Nov 12, 2018
@xeptore @ncoden
Use pull request #11562 from xeptore/patch-1 for v6.5.0
22385e4 
66adaa1 cleanup

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
ncoden pushed a commit to ncoden/foundation-sites that referenced this pull request Nov 12, 2018
@xeptore @ncoden
Use pull request foundation#11562 from xeptore/patch-1 for v6.5.1
82c07b6 
66adaa1 cleanup

Signed-off-by: Nicolas Coden <nicolas@ncoden.fr>
@ncoden ncoden mentioned this pull request Nov 12, 2018
Merged
11 tasks
This was referenced Apr 22, 2020
Open
Open
Merged
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielRuf DanielRuf DanielRuf approved these changes

Assignees
No one assigned
Labels
📖 documentation Grid
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xeptore @DanielRuf @ncoden