Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extends don’t work with libsass #3593

Merged
merged 1 commit into from Nov 25, 2013

Conversation

kennethormandy
Copy link
Contributor

Foundation 5 seems like it’s supposed to work with libsass, which is great! Definitely the right choice. Unfortunately, right now, @extend and % silent classes aren’t suppored in libsass. (The duplicate issues are sass/libsass#80, sass/libsass#137, and sass/libsass#146.)

The feature is supposed to be coming, but right now compiling Foundation with libsass will just output @extend and % literally. Since it’s being used so sparingly anyway, I think all the silent classes should be switched to mixins for the time being.

@Ilyes512
Copy link
Contributor

Ogh, that's not a really nice solution. Now you get a less efficient css file with unnecessary duplicate lines.

Although libsass seems really nice. I don't think it's good for foundation. It's development is low and they still need to get everything working. The @extend is a really must have feature. (So I will keep preprocessing with ruby).

@kennethormandy
Copy link
Contributor Author

You’re right, it definitely adds more CSS, but I think it’s better than having Foundation not compile correctly. I see it as an interim solution; Libsass should get @extend support before the end of the year.

For now, though, Zurb is releasing a command line tool and actively encouraging the use of Foundation and libsass (which is awesome) but Foundation 5 won’t actually compile correctly with it. I’m happy to try and make the solution better, but either way I think it’s important that @extend isn’t used until the feature lands in libsass.

@Ilyes512
Copy link
Contributor

Yes, You are right. It just sucks at the moment for people that don't use Sasslib at all.

mhayes pushed a commit that referenced this pull request Nov 25, 2013
Extends don’t work with libsass
@mhayes mhayes merged commit 43da6c9 into foundation:5.0-wip Nov 25, 2013
@mhayes
Copy link
Contributor

mhayes commented Nov 25, 2013

Totally understand that @extend is pretty awesome but we merged in this pull request because:

  • Most of our underlying Sass code already uses mixins, so this is good in terms of consistency
  • We've committed to libsass support at this time and see a strong future for it. By getting more people using libsass we can help ensure the project continues to thrive!

Once libsass properly supports @extend we'll revisit this issue.

Thanks guys!

@kennethormandy
Copy link
Contributor Author

@mhayes Thanks! Just to make sure, are you still using the 5.0-wip branch? I think you switched to master between when I opened this pull request and now—I should have updated that, sorry.

@mhayes
Copy link
Contributor

mhayes commented Nov 25, 2013

No worries, got it merged into master here: 127788c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants