New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the switch and paddle dimensions to be fully dynamic. #9288

Merged

kball merged 2 commits into foundation:v6.3 from abdullahsalem:fix-switch-height-and-width

Nov 8, 2016

Contributor

abdullahsalem commented Oct 24, 2016

This PR contains the following major changes:

Changed the switch width, paddle width and paddle left to be dynamic.(1)
Fixed the initial value of the paddle's top and left properties.(2)
Removed the switch-size mixin's parameters: $width and $paddle-width.(3)
Changed the switch-size mixin's parameter: $height to $switch-height. (4)

(1)
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR83
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR84
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR85
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR86
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR171
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR172
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR173
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR174

(2)
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR114
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR115

(3)
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acL164
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acL166

(4)
abdullahsalem@53c8121#diff-aac94c109452cecf4dabe6b7d26702acR167


          Changed the switch width, paddle width and paddel left to be dynamic.

53c8121

Fixed the initial value of the paddle's left property.

abdullahsalem mentioned this pull request

Fix $switch-paddle-offset effects. #8804

Closed

Contributor

kball commented Oct 31, 2016

@andycochran or @brettsmason can you take a look at this?

Contributor

andycochran commented Nov 1, 2016

😍 This is really great! Only one note I can think of: $paddle-left-active isn't semantic. Would something like $paddle-active-offest be better?


          Changed the variable name $paddle-left-active to $paddle-active-offest

eda0b3e

Contributor Author

abdullahsalem commented Nov 4, 2016 •

edited

Loading

Done!
You're right, @andycochran!
I've left it as it was. But now it would be more semantic and generic.

kball merged commit 7080ff8 into foundation:v6.3

Contributor

kball commented Nov 8, 2016

Merged! Were there any open issues this addressed?

Contributor Author

abdullahsalem commented Nov 9, 2016

@kball There was only this PR #8804 that guided me to the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet