-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orbit #1856
Comments
I have hacked the timer with .orbit-container .orbit-timer .orbit-progress { background: transparent; } though it was a surprise as well to discover that the timer is dependent on the progress-bar (setting it to display:none broke the slideshow). I second the question about stack_on_small, what's the use for this option? show-timer : [true, false, hover] would be great! Michael is right, all the mechanics of orbit should be moved back to logic. Yours EDIT: and orbit is the only place in foundation I know of, where one needs internationalization: 1 [of | z | ...] 4 (images) A. |
+1 for internationalization. |
+1 |
1 similar comment
+1 |
Huge fan of the grid system in foundation. Great work! I had the same problem as Adam, hiding the timer/progress bar with CSS disables the slideshow and it will only advance manually when choosing either the forward or bullets tabs. Kind of a PITA to figure out why the slider stops working but the work around, for me, was setting the visibility and background of the elements to none, transparent, respectively. This keeps them in the DOM but hides them in your slide content. .orbit-timer, .orbit-progress, .orbit-timer paused, .preloader { visibility: hidden!important; background-color:transparent!important; } Hope this saves someone else some time! |
+1 |
We now have options to turn on/off all of the parts of Orbit. Check out version 4.3! |
Hi,
First, I love Foundation 4, keep the good work.
As for the orbit plugin.
A timer should reside in logic, when controls should reside in the view, so the orbit timer should not be dependent of the physical presence of controls. Timer have a delay value and three states ON, OFF or PAUSED.
In my attempts to hide the progress bar and play control, overriding the selector and setting a display: none on the timer container the timer stop working and only the first slide stayed visible. I still have to check this on other browser than chrome but I don't think it's browser dependent. I did search the matter and haven't found the answer yet.
Check some of yours variables for the slide counter:
in _orbit.scss:
$orbit-slide-number-bg: rgb(0,0,0) !default;
$orbit-slide-number-font-color: #fff !default;
aren't used in
.orbit-slide-number {
position: absolute;
top: 10px;
left: 10px;
font-size: 12px;
span { font-weight: 700; }
}
or elsewhere...
So changing them in _settings.scss it does not take effect and counter keep the global font color style.
What is the intended use of stack_on_small?
Could we have the possibility to set the visibility of the controls. Something like:
Since bullets aren't centered anymore why not move the counter, timer progress-bar and play control on the same row than the bullets when they are visible.
Having controls overlay images isn't much annoyance but for content slide it is.
Thanks a lot for this framework
The text was updated successfully, but these errors were encountered: