Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Realign grid and block-grid's target media queries #3261

Closed
replete opened this issue Sep 14, 2013 · 3 comments
Closed

Suggestion: Realign grid and block-grid's target media queries #3261

replete opened this issue Sep 14, 2013 · 3 comments

Comments

@replete
Copy link

replete commented Sep 14, 2013

Types of horizontal breakpoints used in Zurb 4.3/5 Grid (ignore px metrics):

  • 'Default' = up to 320px
  • 'Small' = wider than 320px
  • 'Medium' = wider than 640px
  • 'Large' = wider than 1024px

But we use these CSS class naming conventions for the grid:

  • small-12 columns = activated for 'Default' = up to 320px
  • medium-8 columns = activated for 'Small' = wider than 320px
  • large-4 columns = activated for 'Medium' = wider than 640px

..and for block-grid:

  • small-block-grid-1 columns = activated for 'Default' = up to 320px
  • medium-block-grid-3 columns = activated for 'Small' = wider than 320px
  • large-block-grid-4 columns = activated for 'Medium' = wider than 640px

This means we're a breakpoint ahead when writing markup, and therefore out of sync. I think it's sometimes confusing.

Suggestion: I believe Foundation would benefit greatly from this subtle realignment:

  • default-12 columns = activated for 'Default' = up to 320px
  • small-8 columns = activated for 'Small' = wider than 320px
  • medium-4 columns = activated for 'Medium' = wider than 640px
  • large-4 columns = activated for 'Large' = wider than 1024px

..and for block-grid:

  • default-block-grid-1 columns = activated for 'Default' = up to 320px
  • small-block-grid-3 columns = activated for 'Small' = wider than 320px
  • medium-block-grid-4 columns = activated for 'Medium' = wider than 640px
  • large-block-grid-4 columns = activated for 'Large' = wider than 1024px

Updated: I'm now using this in a project, here's _grid-5-custom.scss and _block-grid-5-custom.scss

I've suggested default, because in a Mobile-First methodology, it is the 'default' layout. You could use first, primary, or something else, but it feels inappropriate. mobile also feels wrong, even though few browse the internet on calculators.

I've been using Zurb since version 3, and I've grown to love the grid system. Foundation is an excellent achievement, and I'm grateful for what's been created here.

EDIT: If 4 breakpoints were ever not enough for the grid system, though it's hard to imagine, extending with xlarge, extra-large, largest etc would be feasible. Or perhaps the move with F5/6 is to allow you to define your own breakpoints?

@replete
Copy link
Author

replete commented Sep 14, 2013

I'm using this in a project now, and it's working well. Here's the gist, anyway

@andig
Copy link
Contributor

andig commented Sep 25, 2013

This would change about every default layout out there- not such a good idea?

@cmwinters
Copy link
Contributor

Media queries have been redone in 5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants