Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError with sticky top-nav #3608

Closed
mtarnovan opened this issue Nov 22, 2013 · 10 comments
Closed

Uncaught TypeError with sticky top-nav #3608

mtarnovan opened this issue Nov 22, 2013 · 10 comments
Assignees

Comments

@mtarnovan
Copy link

I'm seeing numerous
Uncaught TypeError: Cannot call method 'data' of undefined
triggered by scrolling, around this line in foundation:

var distance = this.settings.sticky_topbar.data('stickyoffset');

The markup:

.contain-to-grid.sticky
  %nav.top-bar(data-options="is_hover:false"  data-topbar)

Forgot to mention: this is with Foundation 5

@muja
Copy link

muja commented Nov 22, 2013

Fix:

js/foundation/foundation.topbar.js, line 38:
self.settings.stick_topbar = topbar;
->
self.settings.sticky_topbar = topbar;

or respective changes in foundation(.min).js

@mtarnovan
Copy link
Author

👍 good catch

@muja
Copy link

muja commented Nov 22, 2013

fixed by Pull Request #3616

@petebot
Copy link

petebot commented Nov 25, 2013

Thanks!

@mrsweaters
Copy link
Contributor

This has been fixed and will be released in 5.0.3

@sdebaun
Copy link

sdebaun commented Dec 12, 2013

fyi -- I just found this bug in foundation.topbar.js, and I downloaded Foundation 5.0.3 for the first time three days ago...?

@sdebaun
Copy link

sdebaun commented Dec 12, 2013

my bad, i just double-checked, and i downloaded the foundation 5.0.2 css-only zip. sorry!

@danheidel
Copy link

I had this same bug as of a fresh download last night. The custom build download link on the website is still serving 5.0.2.

@chrishough
Copy link

Any idea when 5.0.3 will be release? I noticed the rails gem is also still running 5.0.2.

@dkleehammer
Copy link

Any updates about 5.0.3?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants