Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal Modal with disabled CSS setting doesn't fire events. #6500

Closed
jayalfredprufrock opened this issue Apr 24, 2015 · 1 comment
Closed

Comments

@jayalfredprufrock
Copy link

On more than one occasion I've had the need to have greater control over the CSS injected into the modal upon show/hide. If passing in

{ css: { open: {'display':'block'}, close: {'display': 'none'}}}

didn't still inject opacity:1 into the modal things would be great. Unfortunately that's not the case so I must pass in "false" for the css setting. This does prevent the injection of styles, but then events no longer get generated and the "open" class no longer gets toggled. This seems to render the plugin pretty much useless, since now custom events have to be used to get that functionality back. What is the reasoning behind the current implementation?

For instance the "show" function does this:

return el.css(css).show().css({opacity : 1}).addClass('open').trigger('opened').trigger('opened.fndtn.reveal');

which seems kind of silly, but forgive me if I'm missing something.

@rafibomb
Copy link
Member

rafibomb commented Oct 9, 2015

There is definitely and a balance between JS adding markup/CSS and keeping the HTML simple. In the next version there will be a lot less markup added by the JS which will make styling things even simpler.

Especially with the reveal modal, this has been addressed.

@rafibomb rafibomb closed this as completed Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants