-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropdowns hover issues #6704
Comments
Saw the PR here #6705 It would be awesome if you can rework it so we can merge it in. Would help lots of people. Thanks! |
I'd be happy to, but it's unclear to me what the issues are that need to be fixed? We are using the changes from the pull request, and it's working great for us. |
@brianlenz I think @rafibomb is talking about changes to dropdown since your PR. |
I have tested #6705 with these changes and all seems well. 👍 |
Dropdowns hover is running on version 6.3.0. |
@brianlenz Can we close this issue ? |
Sure; we are still using Foundation 5, so we've not had a chance to test on 6.x yet. If/when we upgrade to 6.x, we can deal with any issues separately at that point... Thank you. |
There seem to be two small issues with Foundation's dropdowns:
It's very reasonable that you might want to have a single dropdown that can be displayed at various positions on the page (i.e. triggered from multiple elements). Currently, when you take this approach and hover over the dropdown, the dropdown will move to the position of the first element. It will actually flicker and perform very strangely.
The mouseenter event seems to trigger multiple times as you move your mouse around. This leads to the open/opened events being triggered multiple times (unnecessarily).
The fixes are quite simple, so I will be creating a pull request with the fixes.
The text was updated successfully, but these errors were encountered: