Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reveal height at different vertical scroll positions #6309

Merged
merged 1 commit into from
Feb 25, 2015
Merged

Fix reveal height at different vertical scroll positions #6309

merged 1 commit into from
Feb 25, 2015

Conversation

cpg1111
Copy link
Contributor

@cpg1111 cpg1111 commented Feb 20, 2015

Hi there, this is my fix for issue #6297 so I figured I'd submit a pull request for it.

@bbuchalter bbuchalter mentioned this pull request Feb 23, 2015
Closed
@rafibomb rafibomb added this to the 5.5.2 milestone Feb 25, 2015
jamieshark pushed a commit that referenced this pull request Feb 25, 2015
Merge pull request #6309 from cpg1111/reveal-modal-scroll-position-of…
0dfb336 
…fset

Fix reveal height at different vertical scroll positions
@jamieshark jamieshark merged commit 0dfb336 into foundation:master Feb 25, 2015
@jamieshark jamieshark mentioned this pull request Feb 25, 2015
Closed
@ClemensSchneider
Copy link

Wondering if modal.scrollY was the intended property as it results in NaN for me, too..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@cpg1111 @ClemensSchneider @pdeffendol @jamieshark @rafibomb