Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS is over-reaching #126

Closed
lewisnyman opened this issue Jun 9, 2013 · 2 comments
Closed

CSS is over-reaching #126

lewisnyman opened this issue Jun 9, 2013 · 2 comments

Comments

@lewisnyman
Copy link

The CSS is joyride is making too many assumptions about look and feel, which makes it difficult to integrate into other projects. Setting the font-family is a good example of this. Implementors can either remove the CSS completely, which is tricky because the layout is part of the functionality, or override all the look-and-feel properties in another stylesheet, which is wasteful.

I think the best solution would be to split the CSS into two files, base.css and theme.css, following SMACSS conventions

@mrsweaters
Copy link
Contributor

I am making some major changes to separate styles from the javascript functionality in Joyride 3.0. You can track these changes on the v3 branch. The new structure will be more like Foundation and follow SMACSS conventions.

@sun
Copy link

sun commented Apr 16, 2014

Are there any updates on this? — It looks like the v3 rewrite stalled (around the time of your comment)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants