New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for IE7 and right side orientation. #19
Conversation
ianlewis
commented
Apr 29, 2012
- Support for IE7 on.
- Support for changing the orientation of the tip when it goes outside of the viewport on the right.
- Some indentation and formatting fixes.
- Includes the right alignment support in pull request Can now right align the tip to the target element for the joyride #6
Patch to set position for each element
Removed support for data-position since you can change the position for each tip via data-options Conflicts: jquery.joyride-1.0.4.js
didn't set the options specifically.
The included Modernizr build doesn't include the test for media queries so currently the mobile checks don't work. I wasn't sure how that build was being created so I didn't change it. |
We're using Ian's version in staging. It's a good fix but needs some work. It seems to detect when a right-aligned popup is appropriate but snaps back to it's original position when the browser window is resized. I'll have a look and see if I can patch it up by the weekend so we can push it live. Good work & thanks, great plugin! |
Which browser? I tested resizing and for me it worked. I'd be happy to test and fix it if I can reproduce the problem. |
Might just be a quirk in our app Ian, the demo is working fine for me. Need to have a closer look when I get a chance and see if it's a plugin or app problem. Chrome on Mac currently. |
Thank for your contribution. I'm noticing a resize issue as well. I'll take a look today and see if I can fix it. |
This version is working great for me in IE7 and IE8, thanks Ian! |
There are still issues with these changes in a mobile environment. I think this is mostly due to the resize event not working properly. |
Which mobile environment? I'll give it a try on my test mobiles later. |
I tested it in iOS, did you experience the same issue? |
Fixed the window resize bug and a couple of other things and manually merged into master. Thanks for all the fixes! |
THX! |
I'm pretty sure the Modernizer build needs to be redone to include mediaqueries though. Joyride is checking Modernizer.mediaqueries which is currently undefined. The "Media Queries" checkbox needs to be checked here: |
Here's a jsfiddle that loads the modernizer from tip: http://jsfiddle.net/pVJVW/ |
Now that you mention it, I don't see any method in Modernizr with the "mediaqueries" name. So i've just pushed a new version of the Modernizr, one that just has the "mq" method and update the joyride js. |
Moderizr.mediaqueries is a boolean that gets added by the Media queries extension. Doing media queries without first checking if they are supported will throw errors and break joyride in those browsers. You need to include a Moderizr build that includes that plugin by checking "Media Queries" under "Extra" on the download page. http://modernizr.com/download/ The plugin that adds that is here: https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css-mediaqueries.js |
This is what I've done with the new |