Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IE7 and right side orientation. #19

Closed
wants to merge 12 commits into from

Conversation

ianlewis
Copy link

@ianlewis
Copy link
Author

The included Modernizr build doesn't include the test for media queries so currently the mobile checks don't work. I wasn't sure how that build was being created so I didn't change it.

@JonMidhir
Copy link

We're using Ian's version in staging. It's a good fix but needs some work. It seems to detect when a right-aligned popup is appropriate but snaps back to it's original position when the browser window is resized. I'll have a look and see if I can patch it up by the weekend so we can push it live. Good work & thanks, great plugin!

@ianlewis
Copy link
Author

ianlewis commented May 9, 2012

Which browser? I tested resizing and for me it worked. I'd be happy to test and fix it if I can reproduce the problem.

@JonMidhir
Copy link

Might just be a quirk in our app Ian, the demo is working fine for me. Need to have a closer look when I get a chance and see if it's a plugin or app problem. Chrome on Mac currently.

@mrsweaters
Copy link
Contributor

Thank for your contribution. I'm noticing a resize issue as well. I'll take a look today and see if I can fix it.

@bryannielsen
Copy link

This version is working great for me in IE7 and IE8, thanks Ian!

@mrsweaters
Copy link
Contributor

There are still issues with these changes in a mobile environment. I think this is mostly due to the resize event not working properly.

@ianlewis
Copy link
Author

ianlewis commented Jun 8, 2012

Which mobile environment? I'll give it a try on my test mobiles later.

@mrsweaters
Copy link
Contributor

I tested it in iOS, did you experience the same issue?

@mrsweaters
Copy link
Contributor

Fixed the window resize bug and a couple of other things and manually merged into master. Thanks for all the fixes!

@mrsweaters mrsweaters closed this Jun 22, 2012
@ianlewis
Copy link
Author

THX!

@ianlewis
Copy link
Author

I'm pretty sure the Modernizer build needs to be redone to include mediaqueries though. Joyride is checking Modernizer.mediaqueries which is currently undefined.

The "Media Queries" checkbox needs to be checked here:
http://modernizr.com/download/

@ianlewis
Copy link
Author

Here's a jsfiddle that loads the modernizer from tip: http://jsfiddle.net/pVJVW/

@mrsweaters
Copy link
Contributor

Now that you mention it, I don't see any method in Modernizr with the "mediaqueries" name. So i've just pushed a new version of the Modernizr, one that just has the "mq" method and update the joyride js.

@ianlewis
Copy link
Author

Moderizr.mediaqueries is a boolean that gets added by the Media queries extension. Doing media queries without first checking if they are supported will throw errors and break joyride in those browsers.

You need to include a Moderizr build that includes that plugin by checking "Media Queries" under "Extra" on the download page. http://modernizr.com/download/

The plugin that adds that is here: https://github.com/Modernizr/Modernizr/blob/master/feature-detects/css-mediaqueries.js

@mrsweaters
Copy link
Contributor

This is what I've done with the new modernizer.mq.js file. However, Modernizr.mediaqueries doesn't appear to be defined in it. Unless I'm just not seeing something that's right in front of me. I only see mq defined in that export.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants