postRideCallback argument 'completed' to check if the user has completed all ride #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 10, 2013 17:36
… to true if the user has completed all the ride, otherwise isset to false case the user has aborted the ride before view all tips (on ESC keyor on 'X' click)
|
Hi, Thanks for the PR. Joyride is now part of the Foundation core. Can you please reopen the PR against that branch with any updates needed because we can merge it into Foundation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
postRideCallback now passing a third argument named 'completed'.
This is set to true if the user has completed all the ride(has seen all tips), otherwise is set to false in case the user has not completed the ride (e.g.: on ESC keypress or on 'a.joyride-close-tip' click.