Typings file doesn't compile

[PieterVerledens]

How can we reproduce this bug?
Try to reference the typings file and compile your code. The generic constructor throws an error.
An older version of the file works fine, but doesn't support all the features.

The changes I did on https://github.com/PieterVerledens/tribute allow me to use tribute and compile my project.

Is anyone using the typings file as is without any issues?

[Gunirus]

@benmerckx do you have any examples on how you're using this exactly?

[benmerckx]

It works fine for me on typescript 2.9.2. Maybe I have something misconfigured but it doesn't seem that way (changing the constructor type gives me correct error messages). In any case if you can reproduce this, I think a simple PR changing the constructor to constructor(options: TributeOptions<any>) should do in this case? I see no way around this as it accepts an array of options too which can all be of different type.
Edit: I'm using ts-loader, a webpack loader for compiling. It's possible the loader swallows non-critical errors in d.ts files.

[Gunirus]

node_modules/tributejs/tributejs.d.ts:61:15 - error TS1092: Type parameters cannot appear on a constructor declaration.

61   constructor<T extends {}>(options: TributeOptions<T>)
                 ~~~~~~~~~~~~

Changing the constructor to constructor(options: TributeOptions) seems to compile, I'll test if everything works.

Edit: creating an instance fails when I only change the constructor, I get
TypeError: tributejs_1.default is not a constructor

Any suggestions?

[benmerckx]

Edit: creating an instance fails when I only change the constructor, I get
TypeError: tributejs_1.default is not a constructor

Have a look at --esModuleInterop or import as import * as Tribute from 'tributejs'

Edit: wait it's a type error - I have no clue what's going on then

[Gunirus]

Edit: creating an instance fails when I only change the constructor, I get
TypeError: tributejs_1.default is not a constructor

Have a look at --esModuleInterop or import as import * as Tribute from 'tributejs'

Edit: wait it's a type error - I have no clue what's going on then

Are you using the package 'as-is' in one of your projects?

[agarbund]

I added another PR with a really easy change fixing that issue #149
Note that current .d.ts file doesn't work with the latest Angular (v6).

[mrsweaters]

Thank you guys for reporting this. Can you try the latest release, 3.3.5 and see if that solves your problem. I've merged in @agarbund's PR.

[agarbund]

Yep, works for me.

[mrsweaters]

Sweet! I'm closing it down. Let me know if you guys have any other TypeScript issues.