Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to gogo protobuf #21

Merged
merged 2 commits into from Jan 31, 2017
Merged

switch to gogo protobuf #21

merged 2 commits into from Jan 31, 2017

Conversation

joshuarubin
Copy link
Contributor

@joshuarubin joshuarubin changed the base branch from master to develop January 24, 2017 22:22
@robert-uhl
Copy link
Contributor

As long as the Go gRPC library can handle gogo protobuf messages, then I'm in favour of this change — speed is necessary on the backend.

It'd be nice if we could switch on namespacing. I'm fine with manually asking for it in .proto files, but if folks want to write our own generator that's fine too.

@joshuarubin joshuarubin merged commit c4cfc1a into develop Jan 31, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-11.6%) to 3.587% when pulling c4cfc1a on feature/gogo into d0358d8 on develop.

@joshuarubin joshuarubin deleted the feature/gogo branch January 31, 2017 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshuarubin @robert-uhl @coveralls