Use String#start_with?
to detect leading special character
#12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change uses Ruby's built-in
String#start_with?
, which is implemented entirely in C (in MRI, anyway) and faster than the current implementation.String#start_with?
is available in all versions of Ruby that CSVSafe supports.Benchmarks show a 4.1% speed improvement in line generation.
Legacy code:
This branch:
The
#starts_with_special_character?
method itself is between 20.9% and 28.2% faster, using a similar benchmark.I was unable to find any cases where this branch is slower.