Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase timeout for SendDataResponse to 10s #4258

Closed
AlCalzone opened this issue Feb 18, 2022 · 0 comments · Fixed by #4259
Closed

Increase timeout for SendDataResponse to 10s #4258

AlCalzone opened this issue Feb 18, 2022 · 0 comments · Fixed by #4259
Labels
device compatibility Work that needs to be done to support non-compliant or legacy devices
Projects
Triage

Comments

@AlCalzone
Copy link
Member

This should normally never happen, as this message comes back in milliseconds, but in some circumstances, certain sticks take abnormally long (~8s +/-) to send the response when attempting communication with a dead node. This causes us to break the REQ->RES->Callback cycle and probably cause chaos.
@AlCalzone AlCalzone added the device compatibility Work that needs to be done to support non-compliant or legacy devices label Feb 18, 2022
@zwave-js-bot zwave-js-bot added this to Needs triage in Triage Feb 18, 2022
@AlCalzone AlCalzone mentioned this issue Feb 18, 2022
Merged
Triage automation moved this from Needs triage to Closed Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
device compatibility Work that needs to be done to support non-compliant or legacy devices
Projects
No open projects
Triage
Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: increase default controller response timeout to 10s zwave-js/node-zwave-js
1 participant
@AlCalzone