Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Z-Wave LR Devices Diagnose / Health Check Should Not Allow Health Checks Against anything except the controller #3681

Closed
3 tasks
Botched1 opened this issue Apr 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Botched1
Copy link

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

9.11.1.9e7d24e

ZwaveJS version

12.5.5

Describe the bug

Health Check / Diagnose will allow you to attempt a health check between a Z-Wave LR device and other devices, even though Z-Wave LR devices can't talk directly to anything except the controller.

To Reproduce

From Network Graph view and selecting a Z-Wavew LR end device then click the blue DIAGNOSE button.

Run a health check against any node, except the controller.

It will fail as Z-Wave LR devices can not communicate with other end devices, so should not be allowed at all.

Expected behavior

You should not be able to health check a Z-Wave LRT end device against anything other than the controller.

Additional context

No response

@Botched1 Botched1 added the bug Something isn't working label Apr 22, 2024
@robertsLando
Copy link
Member

Correct, will fix

@robertsLando
Copy link
Member

@robertsLando You can start by hiding the neighbors display when doing health checks on a LR device

cc @AlCalzone I will do it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants