Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): smart start view improvements #3684

Merged
merged 6 commits into from
Apr 26, 2024
Merged

Conversation

robertsLando
Copy link
Member

  • Add a way to easily switch to the node attached to a specific provisioning entry (either by opening a modal there or a link to control panel)
  • Add an info panel to explain some useful info about smart start entries
  • Fill node manufacturer/model/protool informations when missing from QR code but existing nodeId

Fixes #3674

- Add a way to easily switch to the node attached to a specific provisioning entry (either by opening a modal there or a link to control panel)
- Add an info panel to explain some useful info about smart start entries
- Fill node manufacturer/model/protool informations when missing from QR code but existing nodeId
@AlCalzone
Copy link
Member

Some feedback:

  • when including a node via SmartStart while the SmartStart page is open, the "link" to the node does not get updated. We need to be careful though in case the user is editing something, so we don't reload or discard their changes.
  • Should the info panel be there already? I don't see it.
  • The hover effect on the node ID link is too subtle IMO
  • maybe add a tooltip on the grayed out fields of an included node: "The node is already included, so editing its SmartStart settings is not possible."

Copy link
Member

@AlCalzone AlCalzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I'd only show the hint about not being able to edit nodes as a tooltip when hovering the disabled fields.

src/components/custom/MissingKeysAlert.vue Outdated Show resolved Hide resolved
@robertsLando robertsLando merged commit 425a817 into master Apr 26, 2024
9 checks passed
@robertsLando robertsLando deleted the smart-start-improvements branch April 26, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smart Start Screen Data Inconsistencies
2 participants