Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove of failed nodes acts strangely #3693

Closed
3 tasks done
bronger opened this issue Apr 28, 2024 · 3 comments
Closed
3 tasks done

Remove of failed nodes acts strangely #3693

bronger opened this issue Apr 28, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@bronger
Copy link

bronger commented Apr 28, 2024

Checklist

  • I am not using Home Assistant. Or: a developer has told me to come here.
  • I have checked the troubleshooting section and my problem is not described there.
  • I have read the changelog and my problem is not mentioned there.

Deploy method

Docker

Z-Wave JS UI version

9.11.1.e327942

ZwaveJS version

12.5.6

Describe the bug

If I click on “remove” under “Failed nodes” in the “advanced” dialog of a dead node (red sad face), nothing happens. Really nothing, as if it was hanging (which it is not because I can cleanly close the “advanced” dialog).

I can, however, successfully remove the dead node by removing all currenlty dead nodes in the “advanced actions”. However, this opens a lot of red error messages (which I failed to preserve) for all the non-dead nodes.

To Reproduce

See above.

Expected behavior

For using the “remove” button for a single dead node, I expect it to remove the node, possibly after a confirmation dialog.

For using the removal of all currently dead nodes in the “advanced actions”, I got the expected behaviour except for the spurious error messages.

Additional context

I restarted the zwave-JS UI container and retried. I think this time, the symbol was not the red sad face but a grey disc (unknown status?). This was the situation when the ”advanced actions” – “removal of failed nodes” was successful. But I hadn’t tried that before the restart.

@bronger bronger added the bug Something isn't working label Apr 28, 2024
@bronger
Copy link
Author

bronger commented Apr 28, 2024

I experience the same dead buttons for “re-interview node” and “update values”.

Moreover, I see at least one power metering value not being updated, although the load does change definitely. This may or may not be related with the reported issue, but FWIW, it occurs with the same zwave-js-ui versions.

@bronger
Copy link
Author

bronger commented Apr 28, 2024

I do not have this issue with version 9.11.1.9e7d24e.

@robertsLando
Copy link
Member

Fixed on master now, thanks for spotting the error before the official release :)

@bronger bronger changed the title Removed of failed nodes acts strangely Remove of failed nodes acts strangely Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants